fix(restore): estimate tar size portably on macOS - #2922
Open
patil2001 wants to merge 1 commit into
Open
Conversation
estimate_restore_bytes_tar parsed column 3 of tar -tvz, which is the byte size on GNU tar but the group field on BSD tar, so the pre-restore disk-space guard silently became a no-op on macOS. The parser now takes the first pure-numeric byte field, working on both GNU and BSD tar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
estimate_restore_bytes_tar parsed column 3 of tar -tvz, which is the byte
size on GNU tar but the group field on BSD tar, so the pre-restore
disk-space guard silently became a no-op on macOS. The parser now takes
the first pure-numeric byte field, working on both GNU and BSD tar.
AI Assistance
AI helped draft; I reviewed every hunk and ran the checks below.
Release Lane
release/2.6.xmainChanged Surface
Risk And Validation
git diff --checkCommands/results:
Operational Change Check